I think you’re right that there’s no specific need to actually check the currently existing concept if we don’t have specific logic that needs to be triggered when conceptToValidate.getRetired() is true and I don’t think any of the logic in the ticket is specific to unretiring concepts. Basically the idea is that when a concept is unretired, it should be required to pass all validation checks, but we can ignore validation checks when the concept is retired.

Raised a PR for this -

Thanks I was thinking the reverse, that the conceptToValidate could be false in some cases where it is in the process of being unretired. In the code you provided the conceptToValidate.getRetired() is true in the case where the concept is not retired and where the concept is being unretired, then we can perform standard validation in both these cases so don’t need to consider when it is transitioning to unretired. Is that correct or am I misunderstanding?

This is how I am thinking of the three scenarios

1. Concept is retired - conceptToValidate.getRetired() is always True and we skip validation
2. Concept is not retired - conceptToValidate.getRetired() is always False and we perform validation
3. Concept is being unretired - conceptToValidate.getRetired() is always False and we perform validation

So we can handle all three scenarios without checking the existing concept?

Basically, the idea is that the concept as passed to the validator is what the concept will look like, but we should be able to load the existing concept from the DB for comparison.

That’s a really good question. I think the logic would look something like this: