Call-in Information
| Panel |
|---|
Call+1-712-432-0075* or Skype a voice call to freeconferencing |
Screen sharing
Attendance
- Jeremy Keiper
- Sy Haas
- Win Ribeka (visiting - supposed to be on vacation)
- Wyclif Luyima
- Ben Wolfe
- Darius Jazayeri
Tickets to review
- archive:TRAC-2306@ticket Null concept answers in HL7 messages cause HL7InQueue hangup
- archive:TRAC-67@ticket Boolean concepts
- archive:TRAC-2272@ticket Rearrange add, upgrade, and download-from-repository features on module administration page
- archive:TRAC-2148@ticket Can't add regimen
- archive:TRAC-2219@ticket Global properties portlet needs to be able to exclude multiple module framework properties
- archive:TRAC-1385@ticket Changing workflow states on dashboard fails silently if date is blank or before date of start of current state
- archive:TRAC-1928@ticket PatientSetService.getEncounters(Cohort patients) does not return all Encounters
Ticket 2306
- 118 Re-phrase it to 'should not fail with null identifier'
- Assuming the change is effected, the ticket is considered to be approved.
Ticket 67
- Remove unimplemented tests in Obstest.java and Concepttest.java
- ObsTest.java, create two separate for tests at line 216.
- Add test for checking null in case nothing is found for getValueAsBoolean
Ticket 2272
- Approved
Ticket 2148
- Approved
Ticket 2219
- Line 91, fix the text '(Map<@STring;QObject)' generated by the eclipse unit test plugin for openmrs.
- Lines 21, 25, 51, 72 have the same problem of text generated by the eclipse unit test plugin for openmrs
- GlobalPropertyPortletControllerTest.java needs the openmrs licence text
Ticket 1928
- The should annotation on line 325 should match the test method name on line 326 according to openMRS conventions
- PatientSetService.java, line 362, you need to add '@deprecated' javadoc and show what replaced it.