Call-in Information
| Panel |
|---|
Call+1-712-432-0075* or Skype a voice call to freeconferencing |
Screen sharing
Attendance
- Ben Wolfe
- Jeremy Keiper
- Sy Haas
- Win Ribeka
- Wyclif Luyima
- Burke Mamlin
Tickets to review
- archive:TRAC-2126@ticket
- archive:TRAC-2020@ticket
- archive:TRAC-2241@ticket
- archive:TRAC-1458@ticket
- archive:TRAC-1712@ticket
Notes on 2126
- Approved
Notes on 2020
- Needs javadoc comment
- Both classes need to be formatted (control-shift-f)
- Approved (committed can do those)
Notes on 2241
- needs formatted (control-shift-f)
- Add javadoc on isDate to say that "isDate" means "no time", it doesn't mean the java.util.Date that has both date and time
- Approved
Notes on 1458
- Will pose question on dev list
- Obs.hbm: why isn't it one-to-one both ways?
- Put "obs" in the liquibase comment
- Add 'is not null' to select statement in 3156 in liquibase
- Add 'voidReason looks like (new obs id: xx)' to prevent obs that were straight up voided from being
- control-shift-f on Obs.java
- add simple javadocs to setters in obs.java
- EncounterFormController needs control-shift-f
Notes for 1712
- WebModuleUtil:773 needs javadoc on startedModule
- ModuleFactory:724: don't need to catch ModuleException, just let it fall through to throwable
- javadoc on for ModuleUtil.refreshApplicationContext is off. match up param names
- ModuleUtil: can remove moduleexception catch
- moduleUtil: catch of moduleexception isn't needed
- Add comments in moduleactivator interface methods about "willrefreshcontext: will be called multiple times (each time another module is loaded or the dev chooses to refresh the context)
- Module.getActivator: add @deprecated annotation to the method as well
- Module.getModuleActivator/setModuleActivator: don't cast to BaseModuleActivator, just ModuleActivator
- Module.getModuleActivator: don't do a try/catch(ClassCastException), do if (ModuleActivator.class.isAssignableFrom(obj.getClass());
- Add @Deprecated annotation to Activator interface and on methods in class