Call-in Information

Screen sharing

• http://breeze.iu.edu/OpenMRSDev

Attendance

• Ben Wolfe
• Jeremy Kieper
• Sy Haas
• Win Ribeka

  Panel
  Burke Mamlin (*gasp shock faint)

• Wyclif Luyima
• Lu Zhuang Wei
• Darius Jazayeri
• Michael Downey

Tickets to review

• archive:TRAC-908@ticket (re-review after changes)
• archive:TRAC-1615@ticket
• archive:TRAC-227@ticket
• archive:TRAC-1447@ticket

Other TODO items

• Make a ticket for changing Concept.getAnswers() - bwolfe
• Check the saveHandler recursion logic to see if Concept.answers are all being changed when you change a concept
• Design discussion on MlmRule extending Rule
• Design discussion on changing ConceptDerived to ConceptRule
• Check with dev list about registering rule as you get it - nribeka

Notes for ticket 908

• Change concept_answer liquibase update to be an update element instead of a sql element - http://www.liquibase.org/manual/update_data
• Remove new deprecated Concpet.setAnswers(Collection, boolean)
• Remove ConceptAnswerComparator...just use Collections.sort on the list of comparables (ConceptAnswer)
• Add a sentence or two of comments before ConceptAnswersEditor startIdx logic
• Add unit test that touches ConceptAnswersEditor.setAsText
• trivial comment: (double)1 h1. 1d
  (Ticket is approved to be committed assuming Sy does these trivial suggestions)

Notes for ticket 1615

– core patch –

• do a control-shift-o on ConceptFormController
• ConceptDerived.isDerived should not return true on hl7"ZZ". Add ConceptDatype.isRule and that should
• Change ArdenService:173, etc to reference MLMRule in core instead of in org.openmrs.module.dss (should be org.openmrs.arden)
• Change MLMRule to MlmRule
• ArdenService.compile(String) should be named "validateSyntax"
• Try to encapsulte logic in ArdenService.compile(String)
• MlmRule comment: Remove @author from MlmRule
• MlmRule comment: dss_rule reference is wrong.
• MlmRule comment: Define was MLM is.
• Concept.jsp: move language above text of rule
• Concept.hbm.xml: remove length on rule column
• update-to-latest.xml: Language should not be nullable
• ConceptService.getConceptDerived: @since should be 1.7 now
• ConceptService.getConceptDerivedLanguages --> getSupportedConceptDerivedLanguages

– logic module patch –

• RuleTest: lastModified should be saved to a long variables
• CompilingClassLoaderTest: still has printouttablecontents in unit test
• CompilingClassLoaderTest:56: assert that there are some files (because CompilingClassLoaderTest is technically testing two things)
• CompilingClassLoader class javadoc needs more
• CompilingClassLoader: doesn't need -target: 1.5
• CompilingClassLoader:90: add a comment about why the duplicated code
• CompilingClassLoader:111: change .exec(String, String[])
• CompilingClassLoader:130: add to javadoc comment
• CompilingClassLoader:172: change to CNFE(String, ie);
• RuleFactory.getRule, etc needs @shoulds and unit tests
• RuleFactory.getRule:97 isn't registering a rule
• RuleFactory:147: should pass e and second parameter

Notes for ticket 227

• Privilege/Role.hbm.xml needs to keep the discriminator on primary key (on the new role_id and privilege_id)
• Privilege/Role table still needs uuid
• liquibase-update-to-latest: remove changeset 20100311-0211
• liquibase:3246: constraintName should be a descriptive spaceless unique string
• liquibase changeset: break into groupings with preconditions
• liquibase: don't drop uuid
• HibernateUserDao: do a control-shift-o to get rid of bad import
• Role.java: add constructor that takes in an integer role_id
• Privilege.java: add constructor that takes in an integer privilege_id