Call-in Information

Call+1-712-432-0075* or Skype a voice call to freeconferencing
Enter the code*305801

Screen sharing

Add Manage Tokens privilege to logic module - nribeka
LogicService should have a removeToken method...which does the business of removing rules - nribeka

Registered TOken --> Registered Token
Make url tokens.list
Use jquery datatables for paging
use token.form instead of logicToken.form
Make text boxes bigger on token.form
After saving a token, take user to the token.list page
Remove extra white space in ReferenceRule
Don't comment out code that you aren't effecting. LogicRuleToken.serializedUID and LogicRuleToken.rule are needed
In fact, revert all changes in LogicRuleToken
TokenListController.initBinder: this method isn't needed.
Remove all System.out.println: use log.debug instead
TokenListController should not use deleted/not deleted are not localized. use spring messages or Context.getMessageSourceService(). Use arguments for the name of the token deleted
TokenListController: show APIException to the user
TokenListController.formBackingObject: empty else statement
TokenListController, reference privileges in OpenmrsConstants
Need comments in the javascript on validateSelect on logictokenform
validateSelect seems to have an error on line 65
logictokenform needs to use spring:messages
logictokenform: use appropriate "id" on input boxes
logictokenform: use jquery for simple js (like focus)
logictokenformcontroller: put javadoc class comments and license
logictokenformcontroller: look into using spring annotations instead of the logicformcontroller (like the logic tester page that stephen lorenz made)
logictokenformcontroller: why are you using session as the backup to the request parameter

make it DWRHL7Service to make HL7Service
hl7service.startMigration... should not take in a UserContext. have the method call Context.getUserContext()
hl7Service interface should use annotations for authenticated
hl7service methods should throw apiauthentication exception
hl7service methods should throw APIexception with messages in them

hl7service.start/stop* should not return an Object[] if possible. either boolean or void
add logic into hl7migrationthread for if the migration is stopped already, return true (around line 208)
double semi colon in interface
hl7util: don't put another subfolder. use file = OpenmrsUtil.getDirectoryInApplicationDataDirectory(gp) only
localheader: don't call dwr at each page load
use scriptlet or a taglib to call HL7Util.isMigrationNeeded which calls HL7Service.isMigration needed to show/hide the alert

getMaxNumeric: use a variable on line 914 so that you don't call the method three times
getMaxNumeric: look into use Math.min