2010-06-07 Code Review

Call-in Information

Call+1-712-432-0075* or Skype a voice call to freeconferencing
Enter the code*305801

Screen sharing

Attendance

  • Jeremy Keiper

  • Sy Haas

  • Wyclif Luyima

  • Nyoman Ribeka

  • Ben Wolfe

  • Darius Jazayeri

Tickets to review

Ticket 2371

  • add a changeSet to set the default value of the status column to 2 instead of 0

Ticket 1741

  • move changeSet to FormEntry and out of core

Ticket 260

  • go do everything we asked for previously

Ticket 2177

  • liquibase-update-to-latest.xml#3284: split changeset into two (add columns in separate changesets)

  • liquibase-update-to-latest.xml#3285: precondition on changeset is wrong; should be on a column

  • liquibase-update-to-latest.xml#3297: split changeset into multiples and fix precondition

  • liquibase-update-to-latest.xml#3339: needs to be the first changeset

  • liquibase-update-to-latest.xml#3345: comment is wrong (table name is different)

  • use .smallButton instad and just change the width on that class

  • send an email to devlist about your conversion algorithm

  • move ":" to the messages.properties and not in my

  • Don't put the voided checkbox on the concept form. Just use a "remove" button. (and no column name)

  • put the index terms on the concept.jsp

  • change error message to include locale that the error is in

  • You should be able to set localePreferred when creating a concept

  • Change references that were getBestName(Context.getLocale()) to just use getName()

  • DWRConceptService - show concepts with /only/ index terms

  • ConceptListItem - return index term if the index term is the /only/ name. Suffix the index name with " (No fully specified name for this concept)"

  • in COncept.getName(), save getPreferredName(locale) to a temp variable

  • Does Locale have a way to check/get the country variant?