Call-in Information
Call*712-432-0075 or Skype a voice call to freeconferencing
Enter the code*305801
Tickets to review
- #1859 - PatientService should have CRUD methods for PatientIdentifier
- #1809 - Duplicate Concept Names Should Not be Allowed
Review Notes for ticket 1859
- Remove line 1806 and make sure tests run
- Throw an error instead of returning null at line 1212 in the PatientServiceImpl
- Factor some code out of unit test for should void given patient identifier with given reason'' to create separate tests
Review Notes for ticket 1809
- Edit the unit test name at line 24 in the conceptValidatorTest class
- Change the unit test name at line 56 to 'shouldpassIfconceptisretired' in the conceptValidatorTest
- Add a should tag to the service layer for ensuring that concept name look up is case insensitive
- Edit line 157 not to throw a duplicate name exception in the ConceptServiceImpl
To do
- Use stringUtils for string validation checks