[Add User] Password requirements should be shown beforehand as per the global properties

Description

In Add User form (http://localhost:8080/openmrs/admin/users/user.form),

If I choose password as "abc" and submit, error - Please choose a password that is at least 8 characters long

Then I choose "abcdefgh", error - Please choose a stronger password

The I choose "abcdef90", error - Please choose a password that contains both upper- and lower-case letters

The description should be provided at once.

Attachments

2

Activity

Show:

James Arbaugh August 6, 2014 at 10:41 AM

Tested at... http://uat01.openmrs.org:8080/openmrs

Password requirements are now displayed beside the password box: Password should be 8 characters long and should have both upper and lower case characters , at least one digit , at least one non digit

Note 1: there are spaces before the commas, which is not considered proper grammar. This should be fixed.
Note 2: if the username and password are the same when security.passwordCannotMatchUsername=true, the error message is: Please choose a stronger password
Note 3: There is no mention in the password requirement for it to not be the same as the username (if the global property is set for that).
Note 4: If only two global property requirements are true, they should be joined with "and" rather than a comma (,), or they could use commas everywhere. It is currently shown: Password should be 6 characters long and should have at least one digit , at least one non digit

Rafal Korytkowski March 12, 2014 at 1:10 PM

Merged! Thanks!

Ujjwal Arora March 11, 2014 at 9:52 AM

Already made the pull request. forgot to press 'code review'
Please review it - https://github.com/openmrs/openmrs-core/pull/769

Daniel Kayiwa March 11, 2014 at 9:41 AM

Ujjwal are you sting working on this?

Fixed

Details

Assignee

Reporter

Complexity

Low

Designated Committer

Original estimate

Time tracking

1h logged7h remaining

Fix versions

Affects versions

Priority

Created March 4, 2014 at 1:24 PM
Updated August 6, 2014 at 10:41 AM
Resolved March 14, 2014 at 8:17 AM