OCL User Acceptance Testing Feedback

Paging through list of concepts is cumbersome and made worse when the paging links change position on the screen while paging. Keyboard shortcut support would help.

https://talk.openmrs.org/u/burke

MVP: 1

MVP+: 1

For MVP, we'll increase the number of concepts per page to reduce the number of times someone has to click this button

Keyboard support for paging added to MVP+ queue.

Table sorting (by clicking column headers) appears to just sort each page of data being displayed. I’m not sure what it means to sort by “Action”. Maybe it would be better to have sorting options separate from the table (i.e., a “sort by” selector)

https://talk.openmrs.org/u/burke

MVP: 1

MVP+: 1

Remove this sorting for MVP

Add sorting to queue for MVP+

Button styling feels weird. If I hover over a button, it stops looking like a button (e.g., action buttons)

https://talk.openmrs.org/u/burke

MVP

I expected a “clear all” link for Datatypes and Classes (if I’ve checked 5-6 of them, don’t make me manually uncheck all of them to remove filters)

https://talk.openmrs.org/u/burke

MVP

Create Dictionary

gives two options for Preferred Source (CIEL, PIH) but I think the application only really supports CIEL, right? So, remove the PIH option.

https://talk.openmrs.org/u/darius

MVP

Create Dictionary

there’s an option for “Start by copying another dictionary”, but it doesn’t work right. (I tried to copy a dictionary that has 13 concepts, and the resulting dictionary only has 10 concepts.) Please hide this feature for MVP release, and create a ticket about making it work right later.

https://talk.openmrs.org/u/darius

MVP: 1

MVP+: 1

• Dictionary Overview

  • The “By class” breakdown isn’t working right. It shows “Diagnosis: 0” when I have a lot of diagnoses. Fix this if it’s quick (e.g. if it’s just a question of changing “diagnosis” to “Diagnosis” in a query) but if it’s going to take a lot of work, just remove this breakdown for the MVP release.

https://talk.openmrs.org/u/darius

MVP

• Concepts -> Create Custom

  • I try to create a concept with two names in English, the first one has type=Fully Specified, the second has type=Synonym. I get “An error occurred when creating a concept. Invalid name type” for the one that’s a synonym. (Possibly OpenMRS calls this “synonym” but OCL backend calls this nametype=null.)

https://talk.openmrs.org/u/darius

MVP

• Dictionary Overview -> General Details

  • shows “public access: view”. This should instead be “visibility: public”. (I.e. it should be formatted for display the same way that the create screen does it.)

  • should also show the languages. (Can combine default language and other languages to one line for display.)

https://talk.openmrs.org/u/darius

MVP+: 2

• Dictionary Overview -> Actions

  • disable the Release button if there are zero concepts in the dictionary

https://talk.openmrs.org/u/darius

MVP+

• Concepts -> Add from CIEL

  • If I add a concept, it does automatically add Answers and Set Members. This is good. But the flash message should also tell the user that this happened. E.g. “Added ANTENATAL VISIT REASON, and 2 concepts that it depends on.” (maybe even give the names of the extra concepts added).

  • If the user manually removes a concept that was added for being a dependency, I think this will break the import. (E.g. I added ANTENATAL VISIT REASON but then I remove PLANNING PREGNANCY.) We should block the user from removing any concept that’s a dependency of others. (I suspect this is a bit tricky, so marking it post-MVP.)

https://talk.openmrs.org/u/darius

MVP+

• Concepts -> Bulk Add

  • why does the textarea have a loading spinner the first time I open this page?

  • this page needs to block you from navigating away while it’s doing the bulk add (otherwise in-progress work gets lost). Even better is to have some sort of progress report about what’s going on.

  • I added “1, 2, 3, 4, 5”. It told me that 5 and 3 were invalid (good), but then it told me “15 concepts added”, even though it actually only added 3 concepts. Same thing happened with concepts 6,7,8,9,10, there were also two invalid yet it said it was adding 15 concepts.

https://talk.openmrs.org/u/darius

MVP+

• Concepts -> Create Custom

  • language dropdowns for Name and Description should only include supported languages.

  • should have better defaults for name type and preferred-in-language when you add a second name. (i.e. you’re only allowed one fully-specified, and one preferred-in-language, so if the first row has those, the second row should default to Synonym and No)

https://talk.openmrs.org/u/darius

MVP+

• Concepts -> Edit

  • when editing, since OpenMRS UUID and OCL ID are not editable, make them take less space, and get rid of the help text.

https://talk.openmrs.org/u/darius

MVP+

About creating/editing dictionaries

I created a dictionary. Then I click Edit.

•  

  1. It should not show two options where there’s only real option

  2. It shouldn’t change the text for no apparent reason.

• Details: https://talk.openmrs.org/t/ocl-for-openmrs-user-feedback-discussion/21070/44

https://talk.openmrs.org/u/darius

MVP

Then I did something random (closed that dictionary, clicked New Dictionary, then Cancel, then open the first dictionary again and click Edit) and now it looks like it lost a lot of values:

this is an MVP bug. It seems like state is being improperly shared across different instances of opening this form, and this makes me concerned about the underlying code.

Details: https://talk.openmrs.org/t/ocl-for-openmrs-user-feedback-discussion/21070/44

https://talk.openmrs.org/u/darius

MVP

About creating concepts:

• I added “Reasons for Referral” to my dictionary. First it does a nice-looking thing where it shows that it’s going to add 39 dependent concepts, then the number goes up to 42. But then it just says “Finalizing” and it waits there for a long time.

  • That text is not helpful. I would change the initial text to say “Found X dependent concepts to add” and then “Adding and dependent concepts. This may take several minutes. DO NOT NAVIGATE AWAY FROM THE APPLICATION UNTIL THIS IS COMPLETE.”

https://talk.openmrs.org/u/darius

MVP

I left the tab and when I came back to it the message was gone and I didn’t see any of the new concepts in my dictionary. I did a browser refresh and then I could see them. (This is MVP, that when the long-running task completes and you’re looking at the dictionary, it must refresh to show you the new state.)

https://talk.openmrs.org/u/darius

MVP

At this point one of my concepts is being displayed with a French name, and everything else with English:

• Bug (post-MVP I guess)

Details: https://talk.openmrs.org/t/ocl-for-openmrs-user-feedback-discussion/21070/44

https://talk.openmrs.org/u/darius

Localization is an open issue here(https://github.com/OpenConceptLab/ocl_issues/issues/15)

• I try to create a concept with the same name as an existing concept that I already added from CIEL (“Night Blindness”) and the UI never gives me any indication that there was an error. (It showed a yellow message, then refreshed the concept list.). The result was that if I look on the back end my Source did have a concept created, but this was not added to my Collection.

  • I think this is an MVP to fix (i.e. don’t want to ever end up in the state where there is some concept in our Source, but not in the Collection.)

  • Or did we already discuss this and decide it was too hard to fix now?

  • The additional confusing thing for the user is that because of this I have used up an OCL ID, though I cannot see this in the new UI. So if I try to create my next concept with id 1 (since there’s nothing with that ID in the collection yet) I get a different error message that’s hard to interpret, and it disappears after ~5 seconds, which wouldn’t be long enough if I didn’t already know what’s going on. And then whatever I entered is lost. (“An error occurred when creating a concept. Concept with this Mnemonic and Parent id already exists. for all”)

https://talk.openmrs.org/u/darius

MVP+

Dictionary Modal

• Dictionary description doesn’t wrap:

Details: https://talk.openmrs.org/t/ocl-for-openmrs-user-feedback-discussion/21070/45

https://talk.openmrs.org/u/akanter

MVP

Dictionary Modal

• The first time I open the dictionary I see Source0, Class0:

Details: https://talk.openmrs.org/t/ocl-for-openmrs-user-feedback-discussion/21070/45

https://talk.openmrs.org/u/akanter

MVP