Parking Lot: Topics for Subsequent Meetings

Meeting Notes

2023 October

2023-10-10

Attendees:  @Jayasanka Weerasinghe @Ayush Mishra , Edison

@Ayush Mishra 

2023-10-03

Attendees: @Mutagubya Jonathan @Ayush Mishra , Veronica, Edison

@Mutagubya Jonathan 
Almost done with the work on fixing on of the test for 2.x and will create the PR by next week.

@Ayush Mishra 
this pr got merged https://github.com/openmrs/openmrs-esm-patient-management/pull/805
Currently working on fixing the test for the esm-appointments-app. 
Also found one of the bug that was there due to the missing scripts in package.json of the esm-appointments-app. Will create the issue soon

2023 September

2023-09-26

Attendees: 

2023-09-19

Attendees: @Anjula Samarasinghe @Ayush Mishra @Mutagubya Jonathan @Dennis Kigen (Unlicensed) @Randila Premarathne 

@Anjula Samarasinghe 
 Closed the webpack PR since it won't fixed the issue https://github.com/openmrs/openmrs-esm-core/pull/739

@Randila Premarathne 
  mark will setup e2e tests for fast data entry

@Dennis Kigen (Unlicensed) 
Facing some issues with the fixing form builder failing issues 

@Ayush Mishra 

patient chart
worked on visit form component tests in patient chart
vineet suggested more test cases

https://github.com/openmrs/openmrs-esm-patient-chart/pull/1355

looked into lint issues unused functions and variables are not getting detected
dennis worked on some eslint improvements for form builder and will push some updates
https://github.com/openmrs/openmrs-esm-patient-management/pull/812
 

2023-09-12

Attendees: @Ayush Mishra  @Randila Premarathne @Jayasanka Weerasinghe 

• Randila updated the Epic for E2E tests

  • Error rendering macro 'jira' : Unable to locate Jira server for this macro. It may be due to Application Link configuration.

  • TODO: Identify test cases for a repository

  • TODO: Work on setting up a repository (fast data entry app)

• Ayush:

  • TODO: wrap patient chart tests

  • TODO: fix form hooks tests

• TODO: Dilshan work on writing a new test

2023-09-05

Attendees:@Piumal Rathnayake @Jayasanka Weerasinghe @Ayush Mishra @Kakumirizi Daud Pahan, 

•  There are some test failures in the platform tests on the contrib-qa-framework

  • TODO: Share it on the slack

• @Ayush Mishra Opened 2 more PRs:

  • https://github.com/openmrs/openmrs-esm-patient-management/pull/805

  • https://github.com/openmrs/openmrs-esm-patient-management/pull/804

  • TODO: Work on the lint issue

  • TODO: Work on the epic

• Unit and integration coverage: https://docs.google.com/spreadsheets/d/1vOTcL7zNiDJmiqeYJh__5iFiLD9Dtr20pCgQcZf39b0/edit#gid=0

• @Randila Premarathne 
  
  

  • Facing an issue with medications e2e tests

  • TODO: Update the Epic

  • TODO: Setup e2e on other repositories

• Dilan is working on the appointment e2e test

• Ayush - Create a ticket for removing the .env file on management

• Randila - Work on the e2e documentation

• Piumal: TODO: Work on supporting arm64 on pre-filled docker

Open

2023 August

2023-08-29

Attendees: @Anjula Samarasinghe @Piumal Rathnayake @Randila Premarathne @Ayush Mishra @EDISON

• @Randila Premarathne  trying to merge the medication PR

  • Issue with the table, form submit buttons

• @Christopher Lumu was facing some issues with e2e tests

  • @Jayasanka Weerasinghe and @Ian Bacher  Identified the bugs

• @Anjula Samarasinghe

  • Added more tests to cohort builder
    
    

    • 2 more tests needs to be written

    • Drug order flow - Blocked by a backend issue

• @Piumal Rathnayake

  • Added pre-filled docker image integration to the esm-core

  • Opened PR for updating O3-docs

• @Ayush Mishra

  • Worked on the GSoC Report and the video

  • Worked on the status sheet (https://docs.google.com/spreadsheets/d/1vOTcL7zNiDJmiqeYJh__5iFiLD9Dtr20pCgQcZf39b0/edit?usp=sharing)

  • esm-core tests are not running 

    • TODO: Create a ticket

• @Edison is willing to work on the 2.X legacy test migration

2023-08-22

Attendees: @Anjula Samarasinghe @Piumal Rathnayake @Randila Premarathne @Ayush Mishra @Jayasanka Weerasinghe @Kakumirizi Daud 

•  

  • 2.x

    • 2.X Random test failures:

      • TODO: @Kakumirizi Daud @Piumal Rathnayake Find the issue

    • Legacy tests:

      • @Piumal Rathnayake Created an epic: https://issues.openmrs.org/browse/RATEST-353

      • TODO: @Piumal Rathnayake check whether the location test has been already written

  • KenyaEMR QA

    • Instantiated E2E tests.   https://github.com/palladiumkenya/kenyaemr-esm-3.x

    • TODO: Next week: @Anjula Samarasinghe  Complete one tests case. 

  • Cohort Builder 

    • Open

      

      
      TODO: Next week: @Anjula Samarasinghe Complete two test case

    • Failing form builder tests:

      • All of them are fixed now

    • Failing e2e tests due to webpack:

      • https://github.com/openmrs/openmrs-esm-core/pull/739

  • Login and logout PRs on core has been merged.

  • E2E coverage doc

    • https://docs.google.com/spreadsheets/d/12wGW404-KMZqJY8YVm51cTJ8ry6gSa7SiQOcoArqdvI/edit#gid=0

  • Branch protection:

    • TODO: @Jayasanka Weerasinghe update branch rules to make tests mandatory

  • E2E optimisation

    • esm core is remaining
      Next Week: @Piumal Rathnayake  Esm core and documentation

  • TODO: @Randila Premarathne create a ticket to setup 

  • TODO: Next week: @Randila Premarathne Improve the documentation

  • Ayush worked on writing unit tests for appointment and outpatient 

    • TODO: @Ayush Mishra prepare the coverage document

Open

2023-08-15

Attendees: @Anjula Samarasinghe @Piumal Rathnayake @Randila Premarathne @Ayush Mishra @Jayasanka Weerasinghe @Njidda Salifu @Ayush Mishra @Mutagubya Jonathan 

• 2.X E2E tests 

  • There are some tests that needed to be translated to BDD.
    
    

    • TODO: @Piumal Rathnayake create an epic, so that someone can work on it. @Kakumirizi Daud help Piumal to create epics

• KenyaEMR QA

  • @Anjula Samarasinghe worked on writing on unit tests and it is completed! ?

    • https://github.com/palladiumkenya/kenyaemr-esm-3.x/pull/29 

    • Need to initiate E2E tests. 

    • TODO: 

      • To write e2e tests

      • @Jayasanka Weerasinghe merge this: https://github.com/openmrs/openmrs-esm-cohortbuilder/pull/52

• Patient chart has been updated. Most of the PRs from Randila was merged by @Anjula Samarasinghe this week

  • TODO: @Randila Premarathne confirm changes and update tests

  • TODO: @Randila Premarathne Update remaining requested changes on PRs

• PRs for the dynamic frontend is merged.

• Bamboo job for the prefilled docker has been moved

  • TODO: @Jayasanka Weerasinghe run the bamboo job

• @Ayush Mishra opened a set of PR to cover unit tests on the patient management

• Status of coverage:

  • @Randila Premarathne and @Ayush Mishra come up with a detailed report

Open

2023-08-07

Attendees: @Anjula Samarasinghe  @Piumal Rathnayake @Randila Premarathne @Ayush Mishra @Jayasanka Weerasinghe 

• Randila

•  

  • Created a spreadsheet to track the coverage of Test coverage OpenMRS

• TODO: Gherkin

•  

  • Also naming tests

• Anjula

•  

  • Looked into the webpack issue

  •  

    • Created a PR to update the watch ignore: https://github.com/openmrs/openmrs-esm-core/pull/739

  • Had a discussion with valentine from kenyaEMR

  • Started writing some unit tests for kenyaEMR

  • Did the OMRS23 presentation

  • Created the search by demographics E2E test https://github.com/openmrs/openmrs-esm-cohortbuilder/pull/52

• Ayush

•  

  • Started working on writing test for the esm-patient-search-app

  • Fixed the Previous PRs.

TODO

• Create an epic for esm-patient-search-app

• complete tests for compact-patient-search.component.tsx

• Try to complete the tests for esm-patient-search-app

• Piumal:

•  

  • Worked on several PRs

  •  

    • https://github.com/openmrs/openmrs-esm-patient-management/pull/765 https://github.com/openmrs/openmrs-esm-patient-management/pull/763 https://github.com/openmrs/openmrs-esm-patient-management/pull/753 https://github.com/openmrs/openmrs-esm-patient-chart/pull/1304

  • Still waiting until the prefill bamboo job is approved

  • TODO: 

  •  

    • Move the bamboo job into D3X bamboo plan as a stage

    • Optimize the e2e workflows

2023-08-01

Attendees: @Anjula Samarasinghe  @Randila Premarathne @Njidda Salifu 

• 3.x

  • @Randila Premarathne 

    • Added login and logout test 

    • Setup the e2e tests  https://github.com/openmrs/openmrs-esm-core/pull/740

    • Checked the vitals and biometrics validation 

    • TODO:

      • Check the openmrs test coverage

      • Do the requested changes

  • @Anjula Samarasinghe 

    • I research about some tools we can use for the load performance testing

    • I sent a PR the webpack in the core

    • Was preparing for the OMRS23 lighting talk

    • Delivered today OMRS23

    • Need double check the webpack

    • Had a call with valentine regading the kenyEMR testing

2023 July

2023-07-25

Attendees: @Anjula Samarasinghe  @Piumal Rathnayake @Randila Premarathne @Ayush Mishra 

• 3.x

  •   @Randila Premarathne 

    • Covered patient chart repo

    • Opened PR for: Medication & conditions

    • Needs to done changes for the opened PR's 

      • https://github.com/openmrs/openmrs-esm-patient-chart/pull/1292

      • https://github.com/openmrs/openmrs-esm-patient-chart/pull/1288

    • Progress:

      • ? Allergies (PR)

      • ? Programs (PR)

      • ? Vitals & Biometrics (PR)

      • ? Conditions (PR)

      • ? Medication (PR)

    • TODO:

      • Add the requested changes

      • Planning to move on to the core

  • @Piumal Rathnayake 

    • Opened a draft PR for patient registration test failure

      • Added waiting function

      • Updated the mock object

      • https://github.com/openmrs/openmrs-esm-patient-management/pull/763

    • It takes some time to get the API call completed (submit button not getting load)

    • Worked creating a dynamic docker images for the frontend

      • https://github.com/openmrs/openmrs-esm-patient-management/pull/765

      • This will create a production build of the frontend which takes less resources

      • Ias has reviewed the pre-filled docker image pr

    • TODO: 

  • @Anjula Samarasinghe 

    • Working on cohort builder 

    • Opened a pr for search by demographic (https://github.com/openmrs/openmrs-esm-cohortbuilder/pull/52)

    • Configured the tests (https://github.com/openmrs/openmrs-esm-cohortbuilder/pull/51)

    • Still have the issue with submitting forms

    • Created more tickets for cohort builder

    • TODO: Will continue working the cohort builder e2e tests

  • Daud asked to improve the vitals and biometrics form

• Unit & integration

  • @Ayush Mishra

    • Continued working on patient management tests

    • Working on the text person attribute component tests

    • One of the PRs got merged
      
      
      

• Capstone

  • Ethohri still working on the bug

  • @Anjula Samarasinghe needs to have a discussion regarding the project since the ethiohri server is still down

2023-07-18

Attendees: @Anjula Samarasinghe  @Randila Premarathne @Jayasanka Weerasinghe @Piumal Rathnayake  Panendhar

• 3.x

  • @Anjula Samarasinghe 
    
    

    • Created an epic for the Cohort builder e2e coverage

      Error rendering macro 'jira' : Unable to locate Jira server for this macro. It may be due to Application Link configuration.

    • Playwright video tracing blocker: @Dennis Kigen is working on it. 

      • TODO: @Anjula Samarasinghe check for an estimation 

      • https://github.com/openmrs/openmrs-esm-form-builder/pull/148

    • Next week:

      • Setup playwright for the cohort builder

      • Complete

        Error rendering macro 'jira' : Unable to locate Jira server for this macro. It may be due to Application Link configuration.
        (observation/ concept feature )

  • @Piumal Rathnayake 

    • Working on fixing patient registration. 

      • TODO: @Piumal Rathnayake create a fix

      • TODO: @Piumal Rathnayake come up with an estimation

    • Pre-filled Docker container: 

      • PR: https://github.com/openmrs/openmrs-distro-referenceapplication/pull/735

      • TODO: @Piumal Rathnayake open a PR for the frontend fix

    • Next week:

      • complete the pre-filled docker image

  • @Randila Premarathne 

    • Blocker: Forms are not loading in allergies forms. 

      • Possible fixes would be: 

    • Progress:

      • ? Allergies (PR)

      • ? Programs (PR)

      • ? Vitals & Biometrics (PR)

      • ? Conditions

      • ? Medication

    • Next week:

      • = to cover the patients chart

• Capstone:

  • @Anjula Samarasinghe 
    
    

    • facing a blocker with ETHIOHRI migration: https://talk.openmrs.org/t/my-openmrs-fellowship-journey-anjula-samarasinghe/38687/15?u=jayasanka

    • Sent a PR: https://github.com/CDC-HIS/openmrs-esm-ethiohri/pull/54

    • Mitigation:

      • Get started with cohort builder tests

2023-07-11

Attendees: @Anjula Samarasinghe  @Randila Premarathne @Ayush Mishra @Jayasanka Weerasinghe @Piumal Rathnayake 

• 3.x

  • @Randila Premarathne 

    • Previous week:

      • Allergies

      • Programs

      • Vitals & Biometrics

    • Having some trouble with timeout errors in the Allergy forms.

      • TODO: Try disabling the cache and 

    • Having trouble with Dates on Programs

      • Have a debugging session with @Anjula Samarasinghe 

    • Next week

      • Allergies

      • Programs

      • Vitals & Biometrics

      • Conditions

      • Medication

      • = to cover the patients chart

  • @Piumal Rathnayake 

    • Previous week

      • Created a sample bamboo image to generate a pre-filled docker image

        • https://talk.openmrs.org/t/using-pre-filled-docker-images-for-running-e2e-tests/40003/2

        • TODO: @Jayasanka Weerasinghe reply to the thread

    • Next week:

      • Complete the bamboo plan to publish the prefilled image

  • @Ayush Mishra 

    • Previous week:

      • Worked on Add Test for 'display-photo.component.tsx' and 'edit-patient-details-button.component' https://github.com/openmrs/openmrs-esm-patient-management/pull/751

      • Blocker: Having some issues with writing a test for

    • Next week:

      • Complete patient-attribute-field and patient-attributes.resource.ts components

  • @Anjula Samarasinghe 

    • Previous week:

      • Sent a PR to EthiOHRI by adding jest config

        • https://github.com/CDC-HIS/openmrs-esm-ethiohri/pull/53

      • Currently working on:

        • Vitals summary component

        • Blocker: Need a way to find return types of API