2010-05-06 Code Review
Call-in Information
Call+1-712-432-0075* or Skype a voice call to freeconferencing
Enter the code*305801
Screen sharing
Attendance
Jeremy Keiper
Sy Haas
Win Ribeka
Wyclif Luyima
Ben Wolfe
Burke Mamlin
Tickets to review
unnamed link nk1 relationships
unnamed link indexes
unnamed link merge patients
unnamed link login redirect
Notes for 1742
Don't catch generic Exceptions (ORUR01Handler) – catch HL7Exception
400/401 use lowercase boolean
Move relative creation logic in the hl7service. hl7service.processNK1(NK1) which creates a person if necessary and returns the person object for the orur01handler to use
add comment to getnk1list for why the != null is done
HL7ServiceImpl:551 cast as Patient - do not assume Patient is a Person
Create constants:
592, UUID
599, L
603, PN and PI
645 use PatientService
829 change name and use javadoc comments
HL7ServiceTest:489 change to isPatient
ORUR01HandlerTest:430-434 unnecessary
refactor 455-461 to one line
553-557 unnecessary
566-568, 590-591
remove all "purge"s
Ticket 2284
precondition should be indexExists
remove 'failOnError's
Ticket 1716
move the method 'voidPerson' into 'mergePatient' method - ambiguity
Ticket 1998
APPROVED!