/
2010-02-15 Code Review

2010-02-15 Code Review

Aug 18, 2010

<html><head><title></title></head><body>h1. In Attendance

  • Ben Wolfe

  • Sy Haas

  • Wyclif Luyima

  • Jeremy Keiper

Patches Reviewed

#1764: Disable upgrades from additional users if they have already been started by another

  • Patch submitted by: wyclif

  • Leaving updateJobStarted variable alone; seems to do something else unrelated to this issue

  • Triggered by adding a changeset to Liquibase

  • Added a Thread.currentThread().sleep() to the UpdateFilter class to simulate concurrent logins during database update

  • Committed to openmrs-trunk

#2091: Second page of install wizard uses static 'openmrs' for database name table creation line

  • Patch submitted by: jkeiper

  • Looks good (very simple fix)

  • Committed to openmrs-trunk

#2066: Modules should not have to mark core modules as required

  • Patch submitted by: syhaas

  • Tested by putting in DSS module and taking out the logic module

  • Committed to openmrs-trunk and openmrs 1.6.x branch

#2052: Change / remove the logic module tester page

  • Patch submitted by: slorenz

  • messages.properties – had to split into multiple lines; patch generated one long line

Unit tests failing

  • Paul came in and said, “welcome to the team!†because the committed trunk code had failing unit tests

  • changed one timed unit test

    • allow for a delta of 1 second between expected values

  • dssmodule-1.44 is unable to load in unit tests; could be related to #2066

    • Ben changed the code to use his StartModule annotation

    • we digressed into unit test debugging and eventually halted the meeting