2010-06-28 Code Review
Call-in Information
Call+1-712-432-0075* or Skype a voice call to freeconferencing
Enter the code*305801
Screen sharing
Attendance
Jeremy Keiper
Sy Haas
Wyclif Luyima
Nyoman Ribeka
Ben Wolfe
Darius Jazayeri
Tickets to review
unnamed link jquery ui upgrade
unnamed link (syhaas) Active lists
unnamed link (wyclif) Concept Name Tagging Errors
unnamed link Daemon user
Ticket 2406
Approved
Ticket 818
Remove box around "X" (border=0)
allergy remove should not have date
allergy remove should have an other
problem remove should be "Remove from list on _______"
Change "error" to be "Data entry error" (or some other more verbose string)
Ticket 2177
Move liquibase method about escaping wildcards to the hibernateutil
Use LinkedHashSet (which is a Set) instead of ListOrderedSet
change getAllUnRetiredConceptIds to just be getAllUnretiredConceptIds (lowercase R)
change Concept.addName() to change previous names if the given name has a type of FULLY SPECIFIED (same with locale preferred, same with short name)
Link to updateLogs.txt file on Admin-->Database Updates page.
Append to the updateLogs.txt file instead of overwriting it. (rename to liquibaseUpdateLogs.txt)
Will put into crucible and review individually. Disagreements will be commented on Thursday.
Ticket 1947
add a ModuleFactory.startModuleInternal
Fix ScheduleConstnats comments