2010-03-29 Code Review
Call-in Information
Call*712-432-0075 or Skype a voice call to freeconferencing
Enter the code*305801
Tickets to review
unnamed link, Spring 3.0 branch - changeset__12522
Review Notes for ticket 2174
in the setService() method, when replacing a service, you need to re-add the previously added AOP advisors
Review Notes for ticket 2126 (Review Notes for ticket Spring branch)
Add readme file to explain the existence of 2 antlr jars
Rename the lib jars
Take care of autowire in application-context.xml
Delete the static import instead of commenting it out
Modify the file 'openmrs-servlet.xml'
Review Notes for ticket 908
In the file 'liquibase-update-to-latest.xml', update the sort weight column to be none zeros
In the class Concept.java you should deprecate the method getSortAnswers instead of deleting it
Change the modifier for the ConceptAnswerComparator class to protected
Effect point 4 from darius on the comments on the ticket
Review Notes for ticket 2056
Set modifiers on fields at lines 36(personNameValidator) and 39(patientIdentifierValidator) and all other fields inside the validator methods
The patientValidator should be used in the short patientValidator
Change getDead() method to isDead()
Have as few assertions in the a single unit test method, so add separate '@should' annotations and test methods instead of multiple assertions
Delete line 228 in patientForm.jsp
Make a convenience method for lines 83 to 90 to make it more readable