Call-in Information

Screen sharing

• http://connect.openmrs.org

Attendance

• Jeremy Keiper

• Sy Haas

• Wyclif Luyima

• Nyoman Ribeka

• Darius Jazayeri

Tickets to review

• unnamed link (l0s) ConceptService.getConceptDatatype(String) does not work right: More than one ConceptDatatype found with name Date

• unnamed link (zabilcm) Refactor static utility methods in RequiredDataAdvice

• unnamed link (wyclif) Move Hl7_in_archive to filesystem

• unnamed link (aravindm) NPE when validating a numeric obs

• unnamed link (umashanthi) ConceptDatatype needs isComplex and isRule methods

• unnamed link (jimpu2) Add max / min support for logic service

• unnamed link (hablutzel1) Encoding ampersands in languages links in footerFull.jsp

Ticket 1330

• remove unnecessary casting - eclipse "onSave"

  • post to the dev-list about the casting

• ConceptDAO/HibernateConceptDAO

  • deprecate, not replace getConceptDatatypes - keep getConceptDatatype as it is

  • change comment on deprecation

• ConceptService

  • 707: deprecate but leave alone

• Approved: Darius will make minor improvements

Ticket 1670

• Darius: look at subclassing

• Reflect

  • lines 27, 36-38, 70, 81, 105, 126, 134 code style/formatting

  • 46, 56: should return false is not a collection

  • "@shoulds" should not be capitalized

    • use of the Openmrs behavior test generator for @should is recommended

  • rename isAccessible to isSubclass or isSuperclass

• ReflectTest

  • @Verifies and the method names should match

Ticket 2032

• when assigning UserContext use Context.getUserContext instead of passing in the constructor

• rename RESULTSET_SIZE to BATCH_SIZE

Approved pending these changes

Ticket 2203

Approved

Ticket 2265

Approved

Ticket 2175

• just one public method for getMin and one public for getMax, the rest should be private - see Burke's previous comments

Ticket 2349

• import StringEscapeUtils instead of fully specifying