2010-05-17 Code Review

Call-in Information

Call+1-712-432-0075* or Skype a voice call to freeconferencing
Enter the code*305801

Screen sharing

Attendance

  • Jeremy Keiper

  • Sy Haas

  • Wyclif Luyima

  • Ben Wolfe

  • Darius Jazayeri

Tickets to review

  • unnamed link (jkeiper) Adapt R01 handler to create/edit relationships based on NK1 segments in an ORU message

  • unnamed link (jkeiper) HL7InErrors should be created in HL7Service

  • unnamed link (zabilcm) Remove ConceptSet from API

  • unnamed link (raff) Global properties portlet needs to be able to exclude multiple module framework properties

  • unnamed link (umashanthi) Identifier, names and address can have multiple preferred checked at the same time

  • unnamed link (luzhuangwei) Migrate module system to use Liquibase instead of sqldiff

  • unnamed link (bwolfe) Concurrent modification exception on patient dashboard

Ticket 1742

  • change wording of HAPI rendered Messages

  • ORUHandler:428 use StringUtils for String

  • create ticket for moving FormConstants to HL7Constants

Ticket 2322

  • remove line 479 from ORUHandler

Ticket 1921

  • Concept, dont need to deprecate methods 1314 and 1323

    • rename getConceptMembers to getSetMembers

    • remove clearConceptMembers

  • ConceptSet, line 23, not deprecating the class

  • ConceptSetTest, line 745 change UnModifiyable to UnModifiable

Ticket 2219

Approved

Ticket 1663

Approved, pending fixes for NPE for 'current*' when the preferred is not set

Ticket 1474

Ben is taking over

Ticket 2172

Approved