2010-06-17 Code Review
Call-in Information
Call+1-712-432-0075* or Skype a voice call to freeconferencing
Enter the code*305801
Screen sharing
Attendance
Jeremy Keiper
Sy Haas
Wyclif Luyima
Nyoman Ribeka
Ben Wolfe
Darius Jazayeri
Melissa and Hannah, Mt Holyoke College
Draft Forms project (http://openmrs.org/wiki/Draft_Forms_Project)
Tickets to review
unnamed link (astelmashenko) web.xml should have an utf-8 encoding
unnamed link (zabilcm) Refactor static utility methods in RequiredDataAdvice
unnamed link (wyclif) Concept Name Tagging Errors
unnamed link (deuts20h) Implementer not notified when modules don't restart alongside system restart
Ticket 2402
Approve
Ticket 1670
Approved. user applying patch will change @verifies and method names to match
Ticket 2177
right align column labels and put all question marks on labels
put "Continue" button after the notification warnings
put a checkbox for "I accept that these errors exist and want to continue" (or similar) and don't let user continue until clicking
don't mix the warnings and errors. or highlight the errors somehow
use log messages for warnings that don't matter (like "locale for this was set to X")
if same concept has same same conceptname, you can delete duplicate conceptnames. you have to change obs.value_concept_name_id to reference only one
Put deleteforeignkeyconstraint in its own changeset
your preconditions should be comparing what you are actually doing int he changeset because you are using onfail=MARK_RAN. so the precondition should be "if there is a conceptnametagid with id=4", etc
concept names should be allowed to be changed. if a conceptname is changed, instead it should void the the old concept name and add a new concept name with a new conceptname id.
if user doesn't enter a concept name void reason, then put in a string of "Removed from user interface"
put "</ul>" into sb using sb.append() in UpdateFilter
(code review stopped at reviewchanges.vm)
Ticket 1453
make cause nullable in notifySuperUsers. (and change javadoc to say so)
put constant for 512 into Alert class
move startModule(Module) code to the ModuleFactory.startModules() method so that only the unattended module startups notify all admins