2010-03-22 Code Review

Call-in Information

Call*712-432-0075 or Skype a voice call to freeconferencing
Enter the code*305801

Tickets to review

Review Notes for ticket 2120

  • make it work in Firefox

Review Notes for ticket 2141

  • change DatabaseMetaData import to generic JDBC (java.sql) instead of MySQL-specific

  • no need to count tables; just return false if anything exists besides liquibasechangelog or liquibasechangeloglock

  • find a better way to code lines 997 and 998, possibly by using a utility class, and allowing for more drivers than just MySQL

    • the code is hacky by nature

    • needs to be somewhere we can manage it

  • does the wizard still work if the file already exists? is it overwritten or ignored?

Review Notes for ticket 1815

  • factor out HibernatePatientDAO.java:192-201 to HibernateUtil

  • separate tests, one each to find identifiers and names

Review Notes for ticket 2032

  • patch should delete all DAO methods and change getters (i.e. getHl7Archive(), getAllHl7Archives(), etc) to hit the filesystem and return objects, in order to remain transparent to existing code

  • only export and purge messages that are complete (not deleted)

    • leave DELETED messages in the hl7_in_queue table and make sure they do not get processed

  • use id, source and source key to generate filenames

Other to do items