2010-04-29 Code Review
Call-in Information
Call+1-712-432-0075* or Skype a voice call to freeconferencing
Enter the code*305801
Screen sharing
Attendance
Jeremy Keiper
Sy Haas
Win Ribeka
Wyclif Luyima
Darius Jazayeri
Ben Wolfe
Dawn Smith
Tickets to review
Other TODO
Sy wants a wiki page that lists off what versions of what libraries are in each version
Notes for 2291
Readme.txt should say why its named like that
Need a wiki page saying why its like this and how to use it. And suggestions for module developers
Approved
Notes for 1287
LocationTagEditor needs method comments
LocationTagEditor needs @since 1.7
Need @since 1.7 on MetadataComparator (and you're missing a closing parentheses)
Check to see if we have any other Comparators somewhere else
LocationTagValidator might not be needed (OpenmrsMetadataValidator in another ticket)
Don't use the word purge in UI
HierarchyController is in the controller.encounter package...
Use internationalised messages in the jsps, specifically locationTagEdit.jsp has "Properties", "Delete/Retire", "Locations with this tag"
messages.properties: Un-retire -> Unretire
jsp files: don't include jquery because of previous ticket
jsp files: use $j because it'll be in noconflict mode naturally
on the hierarchy view jsp: hierarchy shouldn't look like it's coming out of Admin
Notes for 2165
in the beforeAllTests method, don't do a null check. Better to get the DAO on every test
Notes for 1741
This looks good (although we don't know XSLT), but it's not complete.
Best would be to first do the 'default xstl' ticket, but you could also package this up as a liquibase change
Ask Daniel Kayiwa whether xslt is used by the xforms module