2010-05-24 Code Review
Call-in Information
Call+1-712-432-0075* or Skype a voice call to freeconferencing
Enter the code*305801
Screen sharing
Attendance
Jeremy Keiper
Sy Haas
Wyclif Luyima
Nyoman Ribeka
Ben Wolfe
Darius Jazayeri
Tickets to review
unnamed link (bwolfe) Migrate module system to use Liquibase instead of sqldiff
unnamed link (djazayeri) Location hierarchy select location from tree widget
unnamed link (wyclif) Insertion of True/false concepts should succeed if 'concept' and 'concept_name' tables are empty
Ticket 1474
DatabaseUpdater.java#196: should use the CL parameter instead of OpenmrsClassLoader.getInstance()
Test it with a second module, to make sure it's not running multiple times
Ticket 2335
regular.png: change pointer to a "hand" when hovering over a selectable location
choose-location-widget-type.png: change position / style of the submit button in selecting location display style
openmrs-servlet.xml#42: test ContentNegotiatingViewResolver against the REST Module
openmrs-servlet.xml#90: research conversion-service bean
HierarchyController.java#46: relocate Location.field.style to OpenmrsConstants
openmrs.css#618: check the Manage Obs page, search for a concept and see if removing height has negative affects
locationTree.tag: get rid of ${id} and make the name more specific; generally improve js
Ticket 67
BooleanConceptChangeSet.java#113,124: try to make it not use the isTableEmpty() method