2010-03-30 Code Review

Owned by Former user (Deleted)
Last updated: Jan 03, 2017 by Hillary Bagiire
1 min read

Call-in Information

Call*712-432-0075 or Skype a voice call to freeconferencing
Enter the code*305801

Tickets to review

Review Notes for ticket 2032

  • dwr.xml – change DWRHL7MigrationService to DWRHL7Service (match the name)

*no*InDatabase() methods in HL7Service

*no*InDatabase() methods in HL7Service

  • move migration manipulation logic to the DAO

  • add only one method to the service for accessing this migration logic

  • HibernateHL7DAO#getAllHL7InQueue – change from SQL to Hibernate methods

  • do not put everything in the HL7Util – put them in the service

  • make sure that you can leave the page and come back again without causing errors

  • HL7_ARCHIVE_DIRECTORY_PATH_NAME should be a settings (formerly Global Properties from platform 1.8 downwards)

  • use OpenmrsUtil.getDirectoryInApplicationDataDirectory(String folderName) to get folder names